Skip to content

Fix PostCommit YAML Xlang Direct after Java 17 expansion service upgrade#38962

Open
aIbrahiim wants to merge 1 commit into
apache:masterfrom
aIbrahiim:fix/postcommit-yaml-xlang-direct
Open

Fix PostCommit YAML Xlang Direct after Java 17 expansion service upgrade#38962
aIbrahiim wants to merge 1 commit into
apache:masterfrom
aIbrahiim:fix/postcommit-yaml-xlang-direct

Conversation

@aIbrahiim

@aIbrahiim aIbrahiim commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Fixes: #35198
The PostCommit YAML Xlang Direct was still using Java 11, but #38931 moved the io expansion service to Java 17 so with Java 11, gradle skips shadowJar, so TFRecord xlang tests fail with expansion-service jar not found so we have to use Java 17 for this workflow


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@aIbrahiim aIbrahiim marked this pull request as ready for review June 15, 2026 14:46
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses compatibility issues in the PostCommit YAML Xlang Direct workflow following the migration of the IO expansion service to Java 17. By refactoring the Gradle task dependencies to use a shared preparation task, the build process now correctly handles the required expansion service artifacts, preventing failures caused by missing JAR files.

Highlights

  • Expansion Service Compatibility: Updated the YAML integration test tasks to use a centralized preparation task for expansion services, ensuring compatibility with the recent Java 17 upgrade.
  • Test Infrastructure: Incremented the revision in the trigger file to ensure the PostCommit YAML Xlang Direct test suite is correctly re-run.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/beam_PostCommit_Yaml_Xlang_Direct.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the Gradle build configuration in sdks/python/build.gradle by replacing multiple explicit expansion service dependencies with a single task dependency prepareExpansionServicesForYamlDocs in both yamlIntegrationTests and postCommitYamlIntegrationTests. The review feedback recommends referencing this task as a string literal (e.g., "prepareExpansionServicesForYamlDocs") instead of a bare identifier to prevent potential configuration-time errors (such as MissingPropertyException) when Gradle resolves dependencies lazily.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread sdks/python/build.gradle Outdated
Comment thread sdks/python/build.gradle Outdated
@aIbrahiim aIbrahiim force-pushed the fix/postcommit-yaml-xlang-direct branch from e4c7774 to 77a1530 Compare June 15, 2026 14:54
@github-actions github-actions Bot removed the python label Jun 15, 2026
@Amar3tto Amar3tto requested a review from damccorm June 15, 2026 15:07
@Abacn

Abacn commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

FYI #38965

@aIbrahiim

Copy link
Copy Markdown
Contributor Author

FYI #38965

Thanks, good to know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PostCommit YAML Xlang Direct job is flaky

2 participants