Fix PostCommit YAML Xlang Direct after Java 17 expansion service upgrade#38962
Fix PostCommit YAML Xlang Direct after Java 17 expansion service upgrade#38962aIbrahiim wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses compatibility issues in the PostCommit YAML Xlang Direct workflow following the migration of the IO expansion service to Java 17. By refactoring the Gradle task dependencies to use a shared preparation task, the build process now correctly handles the required expansion service artifacts, preventing failures caused by missing JAR files. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request simplifies the Gradle build configuration in sdks/python/build.gradle by replacing multiple explicit expansion service dependencies with a single task dependency prepareExpansionServicesForYamlDocs in both yamlIntegrationTests and postCommitYamlIntegrationTests. The review feedback recommends referencing this task as a string literal (e.g., "prepareExpansionServicesForYamlDocs") instead of a bare identifier to prevent potential configuration-time errors (such as MissingPropertyException) when Gradle resolves dependencies lazily.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
e4c7774 to
77a1530
Compare
|
FYI #38965 |
Thanks, good to know |
Fixes: #35198
The PostCommit YAML Xlang Direct was still using Java 11, but #38931 moved the io expansion service to Java 17 so with Java 11, gradle skips shadowJar, so TFRecord xlang tests fail with expansion-service jar not found so we have to use Java 17 for this workflow
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.