Skip to content

[Improve] Replace outdated temp directory creation with java.nio.Files #4615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hsuk04 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Improve] Replace outdated temp directory creation with java.nio.Files #4615

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions bookkeeper-server/src/main/java/org/apache/bookkeeper/util/IOUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
package org.apache.bookkeeper.util;

import java.io.File;
import java.nio.file.Files;
import java.nio.file.Path;
import java.io.IOException;
import java.nio.ByteBuffer;
import java.nio.channels.WritableByteChannel;
Expand Down Expand Up @@ -146,14 +148,12 @@ public static File createTempDir(String prefix, String suffix)
*/
public static File createTempDir(String prefix, String suffix, File dir)
throws IOException {
File tmpDir = File.createTempFile(prefix, suffix, dir);
if (!tmpDir.delete()) {
throw new IOException("Couldn't delete directory " + tmpDir);
}
if (!tmpDir.mkdir()) {
throw new IOException("Couldn't create directory " + tmpDir);
}
return tmpDir;
try {
final File tmpDir = Files.createTempDirectory(prefix + suffix).toFile();
return tmpDir;
} catch (IOException e) {
throw new IOException("Could not create temp directory: " + prefix + suffix, e);
}
}

/**
Expand Down