Looking for feedback: adds interceptor lifecycle hook#602
Open
Looking for feedback: adds interceptor lifecycle hook#602
Conversation
This proposes a new hook to allow one to remotely push execution of a Burr Action. For example, if one wants to selectively push remote execution of an action to say Ray, then one can now build an interceptor. This also introduces companion hooks that would run pre & post on the remote to mirror what Burr has today - -I thought it would be simpler to not try to reuse those hooks, and instead make it explicit as to what is going on if you wanted to add something similar. See tests for examples, but open to feedback here. Note: we'd need to think through how this plays with parallelism functionality we have. E.g. currently interceptors aren't propagated to sub applications...
These examples needed to be vetted more. If the interceptors here seem good, we could look to bring them in first class to the library.
|
A preview of is uploaded and can be seen here: ✨ https://burr.dagworks.io/pull/602 ✨ Changes may take a few minutes to propagate. Since this is a preview of production, content with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposes a new hook to allow one to remotely push execution of a Burr Action.
For example, if one wants to selectively push remote execution of an action to say Ray,
then one can now build an interceptor.
This also introduces companion hooks that would run pre & post on the remote to mirror
what Burr has today - -I thought it would be simpler to not try to reuse those hooks, and
instead make it explicit as to what is going on if you wanted to add something similar.
See tests for examples, but open to feedback here.
Note: we'd need to think through how this plays with parallelism functionality we have.
E.g. currently interceptors aren't propagated to sub applications...
Changes
How I tested this
Notes
This change needs to have some thought and discussion.
Checklist