[CALCITE-7337] Add age function (enabled in Postgresql library) #4703

cjj2010 · 2025-12-22T02:42:15Z

jira：https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-7337

we can refer postgresql document about Position:

https://www.postgresql.org/docs/current/functions-datetime.html

link: #4689

xuzifu666

Left some comments，please check them.

testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java

babel/src/test/java/org/apache/calcite/test/BabelTest.java

xuzifu666 · 2025-12-22T06:51:54Z

core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java

+   *
+   * @see <a href="https://www.postgresql.org/docs/current/functions-datetime.html">PostgreSQL AGE</a>
+   */
+  @LibraryOperator(libraries = {POSTGRESQL}, exceptLibraries = {REDSHIFT})


What are the reasons for excluding REDSHIFT here?

What are the reasons for excluding REDSHIFT here?

Because Redshift is based on PostgreSQL, but there are many differences, Redshift does not support age

Perhaps adding DUCKDB is necessary? I'm not very familiar with this area.

Maybe miss here?

Currently, there is no DuckDB library, only a DuckDB dialect, so DuckDB maybe cannot be considered here.

testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java

cjj2010 · 2025-12-22T08:41:21Z

May I ask if this is caused by a code issue？ @xuzifu666

xiedeyantu · 2025-12-22T14:11:47Z

May I ask if this is caused by a code issue？ @xuzifu666

I have rebuilded it, please wait for it.

caicancai · 2025-12-24T02:00:22Z

I will be reviewing this PR in the next couple of days.

caicancai

Jira titles should be in the form of something like "Add LOG1P function (enabled in Spark library)".

caicancai · 2025-12-24T09:32:03Z

testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java

+  /** Test case for
+   * <a href="https://issues.apache.org/jira/browse/CALCITE-7337">[CALCITE-7337]
+   * There is no age function that supports pgSQL</a>. */
+  @Test void testAgePg() {


Need to add invalid date format test？

Need to add invalid date format test？

done, thanks

caicancai · 2025-12-24T09:35:16Z

testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java

+    // Test single timestamp argument (relative to current time)
+    f.checkType("age(timestamp '2023-12-25')", "VARCHAR NOT NULL");
+
+


Extra blank lines

Extra blank lines

done

caicancai · 2025-12-24T09:37:57Z

core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java

+  public static String age(long timestamp) {
+    // Get current date at midnight in UTC
+    long currentTimestamp = Instant.now()
+        .atZone(ZoneOffset.UTC)


Does it have to be UTC?

Does it have to be UTC?

This is just a default strategy, other functions also use UTC. Converting time uniformly to UTC can avoid inaccurate calculations caused by different time zones

Could you please post the relevant PG documentation?

Could you please post the relevant PG documentation?

This pr and jira have doc link，We will find that PG in the document converts the time to the current session time zone and then calculates it

https://www.postgresql.org/docs/current/functions-datetime.html

cjj2010 · 2025-12-25T02:48:20Z

Jira titles should be in the form of something like "Add LOG1P function (enabled in Spark library)".

done

xiedeyantu · 2025-12-25T05:49:51Z

core/src/main/java/org/apache/calcite/util/BuiltInMethod.java

-  FUNCTIONAL_DEPENDENCY_GET_FDS(FunctionalDependency.class, "getFDs");
+  FUNCTIONAL_DEPENDENCY_GET_FDS(FunctionalDependency.class, "getFDs"),
+  AGE(SqlFunctions.class, "age", long.class, long.class),
+  AGE_ONE_PARAM(SqlFunctions.class, "age", long.class);


I'm wondering if we could refer to the implementation of SqlSubstringFunction, since SUBSTRING can also accept two or three parameters. Is it possible to avoid declaring two functions based on the number of input parameters here?

xiedeyantu · 2025-12-25T05:51:21Z

site/_docs/reference.md

 | o p r h | TO_DATE(string, format)                    | Converts *string* to a date using the format *format*
 | o p r | TO_TIMESTAMP(string, format)               | Converts *string* to a timestamp using the format *format*
+| p | AGE(timestamp) | Returns the difference between the current timestamp and the specified timestamp
+| p | AGE(timestamp1, timestamp2) | Returns the difference between timestamp1 and timestamp2


I saw the syntax | b | TRUNC(numeric1 [, integer2 ]) near this line, and I think this form should be used.

xiedeyantu · 2025-12-25T06:04:08Z

core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java

      define(FORMAT_TIME, datetimeFormatImpl);
      define(FORMAT_TIMESTAMP, datetimeFormatImpl);

+      defineReflective(AGE_PG, BuiltInMethod.AGE.method, BuiltInMethod.AGE_ONE_PARAM.method);


If we can support variable input parameters in a single execution function, then we wouldn't need to use defineReflective here, would we? Also, I noticed that DuckDB also supports this function; could we support it as well, and stop using the name AGE_PG?

duckdb> SELECT AGE(timestamp '2023-12-25 08:08:08.080', timestamp '2020-01-01') FROM (VALUES (1)) t; ┌────────────────────────────────────────────────────────────────────────────────────┐ │ age(CAST('2023-12-25 08:08:08.080' AS TIMESTAMP), CAST('2020-01-01' AS TIMESTAMP)) │ ╞════════════════════════════════════════════════════════════════════════════════════╡ │ 0 years 47 mons 24 days 8 hours 8 mins 8.080000000 secs │ └────────────────────────────────────────────────────────────────────────────────────┘

If we can support variable input parameters in a single execution function, then we wouldn't need to use defineReflective here, would we? Also, I noticed that DuckDB also supports this function; could we support it as well, and stop using the name AGE_PG?

duckdb> SELECT AGE(timestamp '2023-12-25 08:08:08.080', timestamp '2020-01-01') FROM (VALUES (1)) t; ┌────────────────────────────────────────────────────────────────────────────────────┐ │ age(CAST('2023-12-25 08:08:08.080' AS TIMESTAMP), CAST('2020-01-01' AS TIMESTAMP)) │ ╞════════════════════════════════════════════════════════════════════════════════════╡ │ 0 years 47 mons 24 days 8 hours 8 mins 8.080000000 secs │ └────────────────────────────────────────────────────────────────────────────────────┘

I strongly agree with this suggestion, done，thanks

xiedeyantu · 2025-12-25T08:49:19Z

core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java

      define(FORMAT_TIME, datetimeFormatImpl);
      define(FORMAT_TIMESTAMP, datetimeFormatImpl);

+      defineMethod(AGE_PG, BuiltInMethod.AGE.method, NullPolicy.STRICT);


AGE_PG change to AGE?

AGE_PG change to AGE?

ok,done

caicancai · 2025-12-25T11:07:44Z

@cjj2010 Thank you for your prompt response, but your commit messages are the same every time, which makes it difficult to understand the focus of your changes. You should make each commit message reflect the content of your changes, and after approval, squash the commit messages and ensure they match the Jira ticket title.

…ction

cjj2010 · 2025-12-26T10:49:32Z

@cjj2010 Thank you for your prompt response, but your commit messages are the same every time, which makes it difficult to understand the focus of your changes. You should make each commit message reflect the content of your changes, and after approval, squash the commit messages and ensure they match the Jira ticket title.

done,thanks

xiedeyantu · 2025-12-26T11:26:29Z

The current code looks fine for me, but I'm not very familiar with the implementation of functions. @xuzifu666 and @caicancai are more familiar with this part, so please see if they have any other comments.
By the way, I don't quite understand why so many additional submissions were added at the end.

xuzifu666 · 2025-12-26T11:45:04Z

There are still conflicts with the main branch, which need to be resolved.

xiedeyantu · 2025-12-27T15:37:12Z

As @xuzifu666 said, I don't think you need to make so many extra commits to indicate what was changed in each part. I understand @caicancai 's suggestion to include relevant commit descriptions later on. If the information you added doesn't affect the overall code, I think it's better to delete it, or you can compress these commits into one and wait for the final review.

caicancai · 2025-12-28T05:37:58Z

Let me try copilot review 😝

Copilot

Pull request overview

This PR adds support for PostgreSQL's AGE function to Apache Calcite. The AGE function calculates the difference between two timestamps and returns it as a formatted string showing years, months, days, hours, minutes, and seconds. The function supports both one-argument (calculates age relative to current time) and two-argument (calculates difference between two timestamps) forms.

Key Changes

Added AGE function implementation in SqlFunctions.java that calculates timestamp differences using Java's Period and Duration APIs
Registered AGE as a PostgreSQL library function in SqlLibraryOperators.java with VARCHAR return type
Added comprehensive test coverage including edge cases for leap years, month boundaries, and negative intervals

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java	Core implementation of the age calculation logic using Period and Duration APIs, supporting 1 or 2 timestamp arguments
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java	PostgreSQL library operator definition with type inference and operand validation
core/src/main/java/org/apache/calcite/util/BuiltInMethod.java	Added AGE enum entry referencing the SqlFunctions.age method
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java	Registered AGE function implementation with NullPolicy.STRICT
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java	Comprehensive unit tests covering various timestamp scenarios, boundary conditions, null handling, and error cases
babel/src/test/java/org/apache/calcite/test/BabelTest.java	Integration tests validating end-to-end execution of AGE function with PostgreSQL library
site/_docs/reference.md	Documentation entry describing the AGE function syntax and behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java

core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java

core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java

babel/src/test/java/org/apache/calcite/test/BabelTest.java

core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java

site/_docs/reference.md

…ors.java Optimize Annotations Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

sonarqubecloud · 2025-12-29T03:09:12Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
96.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

cjj2010 · 2025-12-29T04:44:07Z

There are still conflicts with the main branch, which need to be resolved.

After accepting the suggestion to modify the previously submitted information and then rebase it to the main branch, conflicts will arise. Now that the conflicts have been resolved locally and resubmitted, the detector still shows conflicts. I have to switch to another branch again
link: #4712

Terran added 9 commits December 22, 2025 10:35

[CALCITE-7337] Supports age function for pgSQL

2f65e04

[CALCITE-7337] Supports age function for pgSQL

9ee75dc

[CALCITE-7337] Supports age function for pgSQL

643d6f1

[CALCITE-7337] Supports age function for pgSQL

7fe9218

[CALCITE-7337] Supports age function for pgSQL

de89873

[CALCITE-7337] Supports age function for pgSQL

d9979f5

[CALCITE-7337] Supports age function for pgSQL

0d11ddd

[CALCITE-7337] Supports age function for pgSQL

b8d2e0f

[CALCITE-7337] Supports age function for pgSQL

6784283

cjj2010 mentioned this pull request Dec 22, 2025

[CALCITE-7337] There is no age function that supports pgSQL #4689

Closed

xuzifu666 reviewed Dec 22, 2025

View reviewed changes

Terran added 3 commits December 22, 2025 16:13

[CALCITE-7337] Supports age function for pgSQL

755eed3

[CALCITE-7337] Supports age function for pgSQL

e51561b

[CALCITE-7337] Supports age function for pgSQL

e7d12b0

caicancai self-assigned this Dec 24, 2025

caicancai requested changes Dec 24, 2025

View reviewed changes

caicancai reviewed Dec 24, 2025

View reviewed changes

cjj2010 changed the title ~~[CALCITE-7337] There is no age function that supports pgSQL~~ [CALCITE-7337] Add age function (enabled in Postgresql library) Dec 25, 2025

[CALCITE-7337] Supports age function for pgSQL

e20c3e0

xiedeyantu reviewed Dec 25, 2025

View reviewed changes

[CALCITE-7337] Supports age function for pgSQL

6655acf

xiedeyantu reviewed Dec 25, 2025

View reviewed changes

[CALCITE-7337] Supports age function for pgSQL

0beb4b0

Terran added 2 commits December 26, 2025 14:10

Change age function name AGE_PG to AGE

87c7b24

Merge remote-tracking branch 'origin/pg_age_function' into pg_age_fun…

aaa0730

…ction

Terran added 9 commits December 26, 2025 18:40

Remove blank lines

6359b50

Add boundary date tests and check null

f37769b

Modify unit test comments

9323c4c

Modify unit test comments

a76f899

Modify unit test comments

51c1464

Add illegal timestamp argument test case

ae0bcdc

Optimize the age function to support one or two variable parameters

e5676b8

Change age function name AGE_PG to AGE

743f65e

Merge remote-tracking branch 'origin/pg_age_function' into pg_age_fun…

1261d23

…ction

Modify the annotation content to be consistent with Jira

8d53776

caicancai requested a review from Copilot December 28, 2025 05:37

Copilot started reviewing on behalf of caicancai December 28, 2025 05:37 View session

Copilot AI reviewed Dec 28, 2025

View reviewed changes

cjj2010 and others added 8 commits December 29, 2025 09:32

Update core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperat…

93c9f9b

…ors.java Optimize Annotations Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Remove useless blank lines

2129ed6

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Optimization function usage description

fe591bf

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Remove useless blank lines

8675785

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Optimize function return type determination

c59194e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Optimize the current time format conversion of a single function

bff6b2a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Fix function judgment error

c36b763

Merge branch 'apache:main' into pg_age_function

9f61cf0

cjj2010 mentioned this pull request Dec 29, 2025

[CALCITE-7337] Add age function (enabled in PostgreSQL library) #4712

Merged

cjj2010 closed this Dec 29, 2025

		// Test single timestamp argument (relative to current time)
		f.checkType("age(timestamp '2023-12-25')", "VARCHAR NOT NULL");

[CALCITE-7337] Add age function (enabled in Postgresql library) #4703

[CALCITE-7337] Add age function (enabled in Postgresql library) #4703

Uh oh!

Conversation

cjj2010 commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xuzifu666 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cjj2010 commented Dec 22, 2025

Uh oh!

xiedeyantu commented Dec 22, 2025

Uh oh!

caicancai commented Dec 24, 2025

Uh oh!

caicancai left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjj2010 commented Dec 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xiedeyantu Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

caicancai commented Dec 25, 2025

Uh oh!

cjj2010 commented Dec 26, 2025

Uh oh!

xiedeyantu commented Dec 26, 2025

Uh oh!

xuzifu666 commented Dec 26, 2025

Uh oh!

xiedeyantu commented Dec 27, 2025

Uh oh!

caicancai commented Dec 28, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

cjj2010 commented Dec 22, 2025 •

edited

Loading

xiedeyantu Dec 25, 2025 •

edited

Loading

cjj2010 commented Dec 29, 2025 •

edited

Loading