[CALCITE-7350] Missing allowEmptyOutputFromRewrite parameter in TopDownGeneralDecorrelator.unnestInternal

[xiedeyantu]

See CALCITE-7350

I'm not quite sure how to add test cases. Perhaps we don't need to add test cases related to this change during the evolution process?

[silundong]

Perhaps you could try constructing a Window in correlated subquery (TopDownGeneralDecorrelator can handle window functions in the Project, but it doesn't support Window). For example, in RelOptRulesTest:

final String sql = "SELECT empno FROM emp e WHERE sal > some(SELECT avg(sal) over (partition by deptno) from emp_b b where b.deptno = e.deptno)";

sql(sql)
    .withRule(
        CoreRules.FILTER_SUB_QUERY_TO_MARK_CORRELATE,
        CoreRules.PROJECT_TO_LOGICAL_PROJECT_AND_WINDOW)
    .withLateDecorrelate(true)
    .withTopDownGeneralDecorrelate(true)
    .check();

[xiedeyantu]

Perhaps you could try constructing a Window in correlated subquery (TopDownGeneralDecorrelator can handle window functions in the Project, but it doesn't support Window). For example, in RelOptRulesTest:

final String sql = "SELECT empno FROM emp e WHERE sal > some(SELECT avg(sal) over (partition by deptno) from emp_b b where b.deptno = e.deptno)";

sql(sql)
    .withRule(
        CoreRules.FILTER_SUB_QUERY_TO_MARK_CORRELATE,
        CoreRules.PROJECT_TO_LOGICAL_PROJECT_AND_WINDOW)
    .withLateDecorrelate(true)
    .withTopDownGeneralDecorrelate(true)
    .check();

Thank you for providing the case; I have added it.

[xuzifu666]

LGTM

[xuzifu666]

Please add jira link for it.

[xiedeyantu]

Since it's a minor issue, I simply squashed the commits, thanks!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud