[CALCITE-7259] Drop commons-lang3 dependency#4833
Merged
mihaibudiu merged 1 commit intoapache:mainfrom Mar 18, 2026
Merged
Conversation
mihaibudiu
reviewed
Mar 12, 2026
redis/src/main/java/org/apache/calcite/adapter/redis/RedisSchema.java
Outdated
Show resolved
Hide resolved
redis/src/main/java/org/apache/calcite/adapter/redis/RedisEnumerator.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/apache/calcite/plan/volcano/VolcanoPlannerTest.java
Outdated
Show resolved
Hide resolved
| REGION_MAP.clear(); | ||
| } | ||
|
|
||
| private static boolean equalsIgnoreCase(@Nullable String a, @Nullable String b) { |
Contributor
There was a problem hiding this comment.
this could be in Util, but it's not a must
Replace commons-lang3 usages with local helpers and add lint checks to prevent re-introducing commons-lang3 imports.
macroguo-ghy
force-pushed
the
drop-commons-lang3
branch
from
2f28f3b to
aec13f6
Compare
|
Contributor
|
@macroguo-ghy if you force-push on top of your existing commit I have to re-read all the code again. |
mihaibudiu
approved these changes
Mar 17, 2026
mihaibudiu
added
the
LGTM-will-merge-soon
Contributor
|
If there are no other comments, let's merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace commons-lang3 usages with local helpers and add lint checks to prevent re-introducing commons-lang3 imports.
Jira Link
CALCITE-7259
Changes Proposed
Drop commons-lang3 dependency