putShortVolatile is not volatile in InMemoryTrie#4820
Open
frankgh wants to merge 1 commit into
Open
Conversation
This commit fixes several issues found using the Cassandra edge case explorer skill for the BTI feature. The majority are small findings. Patch by Francisco Guerrero; reviewed by TBD for CASSANDRA-21353
frankgh
commented
May 18, 2026
| final void putShortVolatile(int pos, short value) | ||
| { | ||
| getChunk(pos).putShort(inChunkPointer(pos), value); | ||
| getChunk(pos).putShortVolatile(inChunkPointer(pos), value); |
Contributor
Author
There was a problem hiding this comment.
potentially a copy-paste bug
frankgh
commented
May 18, 2026
| ensuringInBuildInternalContext(operationType), | ||
| getIOOptions().flushCompression, | ||
| getCompressionDictionaryManager()); | ||
| dataWriterOpened = true; |
Contributor
Author
There was a problem hiding this comment.
this is missing setting dataWriterOpened. This doesn't seem to have any functional issues at the moment, but adding the fix for completeness
frankgh
commented
May 18, 2026
| { | ||
| sstable.markSuspect(); | ||
|
|
||
| if (reader != null) |
Contributor
Author
There was a problem hiding this comment.
when an exception occurs, we have a reader that might not get closed properly
frankgh
commented
May 18, 2026
| // Follow end position while we still have a prefix, stacking path. | ||
| go(root); | ||
| while (true) | ||
| try |
Contributor
Author
There was a problem hiding this comment.
this is conforming to the implementation in org.apache.cassandra.io.tries.ValueIterator#initializeWithLeftBound
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes several issues found using the cassandra edge case explorer skill for the BTI feature. The majority are small findings.
Patch by Francisco Guerrero; reviewed by TBD for CASSANDRA-21353