Use smgr-interface provided create_ao function. #1534
Merged
+15
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extensible SMGR is one of usefull Cloudberry features that allow to hijack storage execution flow from extension. smgrcreate_ao however does not follow this memo. Fix that.
x4m
approved these changes
Jan 16, 2026
yjhjstz
reviewed
Jan 16, 2026
yjhjstz
approved these changes
Jan 16, 2026
hw118118
pushed a commit
to hw118118/cloudberrydb
that referenced
this pull request
Jan 27, 2026
* Use smgr-interface provided create_ao function. Extensible SMGR is one of usefull Cloudberry features that allow to hijack storage execution flow from extension. smgrcreate_ao however does not follow this memo. Fix that. * Add assertion and comment
hw118118
pushed a commit
to hw118118/cloudberrydb
that referenced
this pull request
Jan 27, 2026
* Use smgr-interface provided create_ao function. Extensible SMGR is one of usefull Cloudberry features that allow to hijack storage execution flow from extension. smgrcreate_ao however does not follow this memo. Fix that. * Add assertion and comment
hw118118
pushed a commit
to hw118118/cloudberrydb
that referenced
this pull request
Jan 28, 2026
* Use smgr-interface provided create_ao function. Extensible SMGR is one of usefull Cloudberry features that allow to hijack storage execution flow from extension. smgrcreate_ao however does not follow this memo. Fix that. * Add assertion and comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extensible SMGR is one of usefull Cloudberry features that allow to hijack storage execution flow from extension. smgrcreate_ao however does not follow this memo. This commit fixes that.