Suppress DISTRIBUTED BY notices in bfv_joins test#1612
Open
Alena0704 wants to merge 2 commits intoapache:mainfrom
Open
Suppress DISTRIBUTED BY notices in bfv_joins test#1612Alena0704 wants to merge 2 commits intoapache:mainfrom
Alena0704 wants to merge 2 commits intoapache:mainfrom
Conversation
(cherry picked from commit 5794f50416361e8528ae5dfea269eee50261a741)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi, @Alena0704 welcome!🎊 Thanks for taking the effort to make our project better! 🙌 Keep making such awesome contributions!
reshke
approved these changes
Mar 12, 2026
leborchuk
approved these changes
Mar 12, 2026
Contributor
leborchuk
left a comment
leborchuk
left a comment
There was a problem hiding this comment.
Yep, we write warning because want to say users - hey, specify the key explicitly. But don't follow this rule ourselves )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was porting Set join_collapse_limit default value to 13 commit in the open gpdb, I noticed that it caused DISTRIBUTED BY notices in bfv_joins test and fixed it. I suggest considering porting this commit here too.
(cherry picked from commit 5794f50416361e8528ae5dfea269eee50261a741)
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions