Add pre-commit hook mixed-line-ending#274
Conversation
| - id: forbid-submodules | ||
| #- id: mixed-line-ending | ||
| - id: mixed-line-ending | ||
| exclude: ^static/img/.* |
There was a problem hiding this comment.
I think this would need to apply to /blog//.png|jpg|gif as well. I am not sure how advanced the exclude clause syntax is, but sure a lot of images are stowed away in those directories as well.
There was a problem hiding this comment.
@DaanHoogland it is well overdue you need to install pre-commit on your local machine and actually run it and test your PRs and same for the main CloudStack project.
There are no real changes needed here since the tests have passed and I was only really wanting to exclude SVG files.
There was a problem hiding this comment.
good point, @jbampton , but we do need to add that to the wiki/some readme as well. (nothing to do with this commit)
There was a problem hiding this comment.
good point, @jbampton , but we do need to add that to the wiki/some readme as well. (nothing to do with this commit)
There was a problem hiding this comment.
ohw. I see you beat me to it. ;) (ref: apache/cloudstack#11680)
2 participants
https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#mixed-line-ending