ui: allow macaddress input for add nic to vm

[shwstppr]

Description

Fixes #12143

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

vm-add-nic-mac.mp4

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.54%. Comparing base (028dd86) to head (28790e3).
⚠️ Report is 6 commits behind head on 4.20.

Additional details and impacted files

@@              Coverage Diff              @@
##               4.20   #12145       +/-   ##
=============================================
+ Coverage     16.18%   18.54%    +2.36%     
- Complexity    13298    17883     +4585     
=============================================
  Files          5657     5981      +324     
  Lines        498470   608822   +110352     
  Branches      60493    91495    +31002     
=============================================
+ Hits          80660   112891    +32231     
- Misses       408830   483898    +75068     
- Partials       8980    12033     +3053     

Flag	Coverage Δ
uitests	4.29% <ø> (+0.29%)	⬆️
unittests	19.63% <ø> (+2.59%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[shwstppr]

@blueorangutan ui

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12145 (QA-JID-811)

[DaanHoogland]

edit box appears but keep hitting issues in qa. I think these are not related though serious. trying this as admin so the permission denied issues make no sense to me.

[shwstppr]

@DaanHoogland by design I think even root admins cannot deploy or add their own VMs to other user networks

[DaanHoogland]

@DaanHoogland by design I think even root admins cannot deploy or add their own VMs to other user networks

ok, I’ll test some more -tonight or tomorrow- later, I would really like to see the full dialog pass at least once, but I think we’re good to go

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15904

[DaanHoogland]

all good tested as normal user and admin

[DaanHoogland]

all good tested as normal user and admin

🤦 thought it already had a review