Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12196 +/- ##
============================================
- Coverage 17.57% 17.56% -0.01%
+ Complexity 15550 15546 -4
============================================
Files 5913 5913
Lines 529427 529427
Branches 64677 64677
============================================
- Hits 93024 93001 -23
- Misses 425940 425965 +25
+ Partials 10463 10461 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@kiranchavala can you check if this can be targeted to 4.20? |
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix a label issue where ACL name values were displayed with an incorrect label. The change adds a new translation key label.aclname to the English locale file.
- Added
label.aclnametranslation key toui/public/locales/en.json
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "label.accounttype": "Account type", | ||
| "label.acl.export": "Export ACL rules", | ||
| "label.acl.id": "ACL ID", | ||
| "label.aclname": "ACL Name", |
There was a problem hiding this comment.
The translation key label.aclname is added only to en.json, but it should also be added to other locale files for consistency. Other major locale files like zh_CN.json, ja_JP.json, de_DE.json, fr_FR.json, etc., are missing this translation.
Additionally, the existing code in InfoCard.vue (line 586) and VpcTiersTab.vue (line 53) still uses $t('label.aclid') as the label while displaying the aclname value. These should be updated to use $t('label.aclname') to properly fix the label mismatch issue shown in the PR description.
@sureshanaparti the issue is not present in 4.20.1 |
| "label.accounttype": "Account type", | ||
| "label.acl.export": "Export ACL rules", | ||
| "label.acl.id": "ACL ID", | ||
| "label.aclname": "ACL Name", |
There was a problem hiding this comment.
can be moved after label.aclid to maintain the order
There was a problem hiding this comment.
or better change label name to label.acl.name in both files
|
closing in favour of #12511 |
This pr fix the label issue
Create a vpc tier and associate a acl rule to it and check the network details
Before the fix
After fix