fix template id unmanaged vm#12288
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12288 +/- ##
============================================
+ Coverage 17.48% 17.51% +0.02%
- Complexity 15553 15585 +32
============================================
Files 5914 5914
Lines 529678 529869 +191
Branches 64718 64723 +5
============================================
+ Hits 92628 92783 +155
- Misses 426605 426635 +30
- Partials 10445 10451 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java
Outdated
Show resolved
Hide resolved
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16102 |
Co-authored-by: dahn <daan.hoogland@gmail.com>
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16141 |
|
@blueorangutan test |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-15051)
|
|
@nvazquez , any specific test you advise? or can we merge with regression tests only? |
|
Awesome work, congrats on your first merged pull request! |
Description
This PR will fix the template fallback for KVM host.
Link previous PR: #11640 (comment)
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
If you import vm on 4.22 kvm tempalte will be re-created on DB
How did you try to break this feature and the system with this change?