Replace deprecated 'egrep' commands with 'grep -E'.#12306
Replace deprecated 'egrep' commands with 'grep -E'.#12306DaanHoogland merged 1 commit intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
|
@blueorangutan package |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12306 +/- ##
============================================
+ Coverage 3.58% 17.50% +13.91%
- Complexity 0 15568 +15568
============================================
Files 445 5914 +5469
Lines 37571 529623 +492052
Branches 6921 64683 +57762
============================================
+ Hits 1347 92695 +91348
- Misses 36058 426481 +390423
- Partials 166 10447 +10281
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16104 |
|
@blueorangutan test |
|
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-15032)
|
|
[SF] Trillian test result (tid-15036)
|
|
@weizhouapache , I don’t think we need more than the regression tests for this one. agree? |
yes, agree. |
|
Awesome work, congrats on your first merged pull request! |
Co-authored-by: Sander Grendelman <sander.grendelman@axians.com>
Description
This PR changes several instances where the deprecated
egrepcommand is used in stead ofgrep -E.There should be no functional difference between the two forms of this command.
In (at least) EL10 the usage of de deprecated form leads to errors like:
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Trivial change, there is no functional difference between
egrepandgrep -E.How did you try to break this feature and the system with this change?