fix: NsxResource.executeRequest DeleteNsxNatRuleCommand comparison bug#12311
Open
wolfchkov wants to merge 1 commit intoapache:mainfrom
Open
fix: NsxResource.executeRequest DeleteNsxNatRuleCommand comparison bug#12311wolfchkov wants to merge 1 commit intoapache:mainfrom
wolfchkov wants to merge 1 commit intoapache:mainfrom
Conversation
DaanHoogland
approved these changes
Dec 20, 2025
Contributor
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm, tnx @wolfchkov
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #12311 +/- ##
=============================================
- Coverage 17.51% 3.58% -13.93%
=============================================
Files 5914 445 -5469
Lines 529867 37618 -492249
Branches 64722 6941 -57781
=============================================
- Hits 92782 1347 -91435
+ Misses 426635 36105 -390530
+ Partials 10450 166 -10284
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes an issue in NsxResource.executeRequest where Network.Service comparison failed when DeleteNsxNatRuleCommand was executed in a different process. Due to serialization/deserialization, the deserialized Network.Service instance was not equal to the static instances Network.Service.StaticNat and Network.Service.PortForwarding, causing the comparison to always return false. fix
wolfchkov
force-pushed
the
fix-delete-nsx-rule-cmd-execution
branch
from
228376f to
57129ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue in NsxResource.executeRequest where Network.Service comparison failed when DeleteNsxNatRuleCommand was executed in a different process. Due to serialization/deserialization, the deserialized Network.Service instance was not equal to the static instances Network.Service.StaticNat and Network.Service.PortForwarding, causing the comparison to always return false.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Rewrite unit test to check this bug.
How did you try to break this feature and the system with this change?