Skip to content

pre-commit: fix inconsistent license#12551

Merged
shwstppr merged 1 commit intoapache:4.22from
shwstppr:fix-precommit-vuelicense
Jan 30, 2026
Merged

pre-commit: fix inconsistent license#12551
shwstppr merged 1 commit intoapache:4.22from
shwstppr:fix-precommit-vuelicense

Conversation

@shwstppr
Copy link
Contributor

Description

Fix inconsitent license

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr force-pushed the fix-precommit-vuelicense branch from ecaf80b to 7b79d3b Compare January 29, 2026 19:13
@shwstppr shwstppr changed the base branch from main to 4.22 January 29, 2026 19:13
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.87%. Comparing base (f5778ea) to head (7b79d3b).
⚠️ Report is 1 commits behind head on 4.22.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #12551      +/-   ##
============================================
+ Coverage     17.61%   17.87%   +0.26%     
- Complexity    15659    16069     +410     
============================================
  Files          5914     5935      +21     
  Lines        530807   532338    +1531     
  Branches      64856    65086     +230     
============================================
+ Hits          93512    95181    +1669     
+ Misses       426781   426510     -271     
- Partials      10514    10647     +133     
Flag Coverage Δ
uitests 3.57% <ø> (-0.03%) ⬇️
unittests 18.98% <ø> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shwstppr shwstppr marked this pull request as ready for review January 30, 2026 03:50
@shwstppr shwstppr requested a review from sudo87 January 30, 2026 03:50
Copy link
Collaborator

@sudo87 sudo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sudo87
Copy link
Collaborator

sudo87 commented Jan 30, 2026

Thank you @shwstppr for this pr.

Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@shwstppr
Copy link
Contributor Author

pre-commit GHA passes, merging

@shwstppr shwstppr merged commit d7bdbcc into apache:4.22 Jan 30, 2026
22 of 28 checks passed
@shwstppr shwstppr deleted the fix-precommit-vuelicense branch January 30, 2026 04:35
@shwstppr shwstppr requested a review from DaanHoogland January 30, 2026 06:10
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for me this looks good, but @jbampton made the auto license action workflow. Any comments on the extra white spaces?

@jbampton
Copy link
Member

for me this looks good, but @jbampton made the auto license action workflow. Any comments on the extra white spaces?

The original has the extra spaces:

https://github.com/apache/cloudstack/blob/main/LICENSE.header

The existing codebase for example the Java files do have this style of license with the extra spaces

sandeeplocharla pushed a commit to NetApp/cloudstack that referenced this pull request Feb 6, 2026
Fix inconsistent license with UI .vue file.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

5 participants