Skip to content

server: fix template type of ISO uploaded from local#12587

Closed
weizhouapache wants to merge 1 commit intoapache:4.22from
weizhouapache:4.22-fix-template-type-of-iso-from-local
Closed

server: fix template type of ISO uploaded from local#12587
weizhouapache wants to merge 1 commit intoapache:4.22from
weizhouapache:4.22-fix-template-type-of-iso-from-local

Conversation

@weizhouapache
Copy link
Contributor

Description

This PR should fix #12104

a regression of #11682

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache added this to the 4.22.1 milestone Feb 4, 2026
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.62%. Comparing base (b869913) to head (710f035).

Files with missing lines Patch % Lines
...n/java/com/cloud/template/TemplateManagerImpl.java 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #12587      +/-   ##
============================================
- Coverage     17.62%   17.62%   -0.01%     
  Complexity    15663    15663              
============================================
  Files          5915     5915              
  Lines        531171   531173       +2     
  Branches      64938    64939       +1     
============================================
- Hits          93601    93599       -2     
- Misses       427031   427033       +2     
- Partials      10539    10541       +2     
Flag Coverage Δ
uitests 3.71% <ø> (ø)
unittests 18.69% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant