Unhide setting js.interpretation.enabled#12605
Open
winterhazel wants to merge 1 commit intoapache:4.20from
Open
Unhide setting js.interpretation.enabled#12605winterhazel wants to merge 1 commit intoapache:4.20from
js.interpretation.enabled#12605winterhazel wants to merge 1 commit intoapache:4.20from
Conversation
Member
Author
|
@blueorangutan package |
js.interpretation.enabled
|
@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 4.20 #12605 +/- ##
=========================================
Coverage 16.26% 16.26%
+ Complexity 13429 13428 -1
=========================================
Files 5661 5661
Lines 500010 500033 +23
Branches 60715 60717 +2
=========================================
+ Hits 81331 81349 +18
- Misses 409606 409611 +5
Partials 9073 9073
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16729 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR proposes unhiding
js.interpretation.enabled. For reference regarding why, see the discussion in #12523.Also, the configuration was made dynamic, and some extra refactoring was performed to organize the code (
JsInterpreterHelperalready exists inmain).Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
How Has This Been Tested?
js.interpretation.enabled.Before the changes:
In the logs:
After the changes:
js.interpretation.enabledwas disabled. When the setting was enabled, I was able to create them successfully.