UI: Keyboard Shortcut(s)

[apurv-1]

Description

Adds the support to navigate through CloudStack Management UI with Keyboard.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale

• Major
• Minor

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[apurv-1]

@borisstoyanov can we show the list of keyboard shortkeys in a different way? for eg: github (shift+?)

cc: @rohityadavcloud

[borisstoyanov]

nice, great to see you back on this @apurv-1! The list you suggest seems good, let me know if you need any help/testing

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0bc7fb5) 30.75% compared to head (4082d43) 31.22%.

❗ Current head 4082d43 differs from pull request most recent head b0ecf89. Consider uploading reports for the commit b0ecf89 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8250      +/-   ##
============================================
+ Coverage     30.75%   31.22%   +0.47%     
+ Complexity    33910    31081    -2829     
============================================
  Files          5341     4839     -502     
  Lines        374759   338361   -36398     
  Branches      54510    48669    -5841     
============================================
- Hits         115248   105657    -9591     
+ Misses       244276   218202   -26074     
+ Partials      15235    14502     -733     

Flag	Coverage Δ
simulator-marvin-tests	25.15% <ø> (+0.50%)	⬆️
uitests	?
unit-tests	14.81% <ø> (-1.63%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vishesh92]

@blueorangutan ui

[blueorangutan]

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8250 (QA-JID-228)

[yadvr]

Excellent, thanks for raising this @apurv-1

[DaanHoogland]

@apurv-1 I know I have asked this and you replied but I can not find the dialog above so;

Will you add the other shortcuts from the old PR as well?

[apurv-1]

@apurv-1 I know I have asked this and you replied but I can not find the dialog above so;

Will you add the other shortcuts from the old PR as well?

Yeah, I am planning to add older shortcuts and but to display shortcuts, I am inclining the way github shows it i.e by opening a dialog. (We can discuss more on this, its just a suggestion right now)

[DaanHoogland]

@apurv-1 I know I have asked this and you replied but I can not find the dialog above so;
Will you add the other shortcuts from the old PR as well?

Yeah, I am planning to add older shortcuts and but to display shortcuts, I am inclining the way github shows it i.e by opening a dialog. (We can discuss more on this, its just a suggestion right now)

ok, so do you want this merged as is or add to it first?

[DaanHoogland]

@apurv-1 please see the failures in the UI build: https://github.com/apache/cloudstack/actions/runs/6914183873/job/18841522093?pr=8250

[apurv-1]

@apurv-1 I know I have asked this and you replied but I can not find the dialog above so;
Will you add the other shortcuts from the old PR as well?

Yeah, I am planning to add older shortcuts and but to display shortcuts, I am inclining the way github shows it i.e by opening a dialog. (We can discuss more on this, its just a suggestion right now)

ok, so do you want this merged as is or add to it first?

I will add the more shortcuts then add the dialog then it will be ready for merge. Sorry, for confusion will change this to draft PR 😅

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[yadvr]

@apurv-1 thanks for the PR (again), could you resolve the conflict? Thanks.

[apurv-1]

@apurv-1 thanks for the PR (again), could you resolve the conflict? Thanks.

Yeah, Sure

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.52%. Comparing base (f417c6b) to head (47bbde0).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8250      +/-   ##
============================================
+ Coverage     17.46%   18.52%   +1.06%     
- Complexity    15516    15520       +4     
============================================
  Files          5913     5468     -445     
  Lines        529385   491833   -37552     
  Branches      64679    57765    -6914     
============================================
- Hits          92448    91105    -1343     
+ Misses       426518   390474   -36044     
+ Partials      10419    10254     -165     

Flag	Coverage Δ
uitests	?
unittests	18.52% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

@blueorangutan ui

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8250 (QA-JID-315)

[DaanHoogland]

clgtm and tested in qa

[DaanHoogland]

@harikrishna-patnala @shwstppr @borisstoyanov let's merge this finaly

[apurv-1]

@DaanHoogland we can merge this and then have follow up PRs for improvements. We can start with "what are the 10 most used actions that user performs on the UI"? I can start with adding shortkeys for those actions.

[DaanHoogland]

@DaanHoogland we can merge this and then have follow up PRs for improvements. We can start with "what are the 10 most used actions that user performs on the UI"? I can start with adding shortkeys for those actions.

Agree, @apurv-1 . I think this would be a good topic to start a new discussion on ;)

[vladimirpetrov]

@blueorangutan package

[blueorangutan]

@vladimirpetrov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[apurv-1]

@DaanHoogland we can merge this and then have follow up PRs for improvements. We can start with "what are the 10 most used actions that user performs on the UI"? I can start with adding shortkeys for those actions.

Agree, @apurv-1 . I think this would be a good topic to start a new discussion on ;)

@DaanHoogland started a discussion here :)

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9348

[vladimirpetrov]

Hi @apurv-1, I tested the feature but it seems that the 'r' shortcut doesn't work on the following pages:

• 'Domains' page
• 'Infrastructure' summary page
• 'Infrastructure' - CPU sockets page
• 'Infrastructure' - DB/Usage server page
• 'Configuration' - Global Settings
• 'Tools' - Import-Export Instances

[DaanHoogland]

@vladimirpetrov , do you think that needs to be implemented before we can merge?

[vladimirpetrov]

Well, I think we should be consistent - wherever there is a 'Refresh' button, the shortcut must work, so yes, @DaanHoogland

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[DaanHoogland]

@vladimirpetrov I do not think any more effort is going to be put into this. jfyi

[DaanHoogland]

@vladimirpetrov (cc @apurv-1 ) I merged main. lets create a new issue from your comment #8250 and continue with this if it tests ok?

[DaanHoogland]

Well, I think we should be consistent - wherever there is a 'Refresh' button, the shortcut must work, so yes, @DaanHoogland

I do not agree @vladimirpetrov . Better to have inconsistent keyboard shortcut then to have none.