fix: Native engine crashes on literal DateTrunc and TimestampTrunc#3668
Open
0lai0 wants to merge 2 commits intoapache:mainfrom
Open
fix: Native engine crashes on literal DateTrunc and TimestampTrunc#36680lai0 wants to merge 2 commits intoapache:mainfrom
0lai0 wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
|
Broadcasting scalars to arrays to fit existing API limitations seems like a hack. It also means in the (scalar, scalar) case we return an array, when we could also return a scalar. |
Contributor
Author
|
Thanks @mbutrovich for the reminder—I’ve updated the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3342
Rationale for this change
When ConstantFolding is disabled, literal trunc() and date_trunc() calls reach the native engine with both arguments as Scalar. The existing match arms only handled (Array, Scalar) and (Array, Array) , so the (Scalar, Scalar) case fell through to the error branch and crashed.
What changes are included in this PR?
Use into_array(num_rows) to convert the date argument to an Array before matching on format, so all input combinations are handled uniformly.
Convert the timestamp argument to an Array via into_array(num_rows) before matching on format.
How are these changes tested?
Added test cases in
CometTemporalExpressionSuitethat disable ConstantFolding and verify literaltrunc()anddate_trunc()queries execute correctly on Comet and produce results matching Spark.