test: enable float/double/binary array casts to string#4386
Draft
manuzhang wants to merge 1 commit into
Draft
Conversation
manuzhang
force-pushed
the
codex/array-string-cast-types
branch
from
3861785 to
460615e
Compare
manuzhang
changed the title
Enable FloatType, DoubleType, and BinaryType in CometCastSuite's ArrayType-to-StringType coverage. Allow ArrayType(BinaryType) casts to string to use the existing native binary string formatting path. Co-authored-by: Codex <codex@openai.com>
manuzhang
force-pushed
the
codex/array-string-cast-types
branch
from
460615e to
413d575
Compare
manuzhang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A.
Rationale for this change
CometCastSuitehad FloatType, DoubleType, and BinaryType commented out forArrayTypetoStringTypecasts. The native cast path already handles floating-point elements, and BinaryType can use the existing native binary string formatting path when arrays cast their elements to strings.What changes are included in this PR?
CometCastSuite.cast ArrayType to StringType.ArrayType(BinaryType) -> StringTypeso it follows normal element string-cast support.How are these changes tested?
./mvnw test -Pspark-4.1 -Dtest=none -Dsuites="org.apache.comet.CometCastSuite cast ArrayType to StringType"Co-authored-by: @codex