-
Notifications
You must be signed in to change notification settings - Fork 144
Build in debug mode for PRs #1375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ding the wheel artifacts from build stage
…pushes to main and release or candidate tags.
…s erasing the other wheel
Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors CI to use reusable build/test workflows and to run PR builds in debug mode for faster feedback while keeping release-mode builds for main and tags.
Changes:
- Split CI into reusable workflows (
build.yml,test.yml) and added dedicated entry workflows for PRs (ci.yml) and releases (release.yml). - Updated test workflow to install and test against the pre-built Linux wheel artifact instead of rebuilding during tests.
- CI/config formatting cleanups across TOML files and adjusted license generation to rely on
cargo-license.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Formatting cleanup and a dependency list syntax fix (trailing comma). |
| examples/datafusion-ffi-example/Cargo.toml | TOML formatting cleanup for pyo3 features list. |
| examples/datafusion-ffi-example/.cargo/config.toml | TOML formatting cleanup for rustflags. |
| dev/create_license.py | Switches license generation to call cargo-license directly. |
| .github/workflows/test.yml | Converts to reusable workflow and installs pre-built wheel artifacts for tests. |
| .github/workflows/release.yml | Adds release entry workflow calling reusable build/test in release mode. |
| .github/workflows/ci.yml | Adds PR entry workflow calling reusable build/test in debug mode. |
| .github/workflows/build.yml | Converts to reusable workflow; adds linting jobs and reworks wheel build/artifact behavior. |
| .cargo/config.toml | TOML formatting cleanup for rustflags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This PR is to improve our CI performance in a couple of ways