Restore Sort unparser guard for correct ORDER BY placement (v2)#20923
Open
alamb wants to merge 4 commits intoapache:mainfrom
Open
Restore Sort unparser guard for correct ORDER BY placement (v2)#20923alamb wants to merge 4 commits intoapache:mainfrom
alamb wants to merge 4 commits intoapache:mainfrom
Conversation
alamb
changed the title
26 tasks
Contributor
|
Apologies for not updating original PR - was busy last couple days. Thanks @alamb! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Fixes a regression in the unparser introduced in Datafusion 52, as described by @krinart in #20658
I can't fix #20658 because I can't push to the fork, so I made a new PR to resolve a merge conflict and apply some suggestions
What changes are included in this PR?
Are these changes tested?
By CI and new tests
Are there any user-facing changes?
Bug fix