Add support for nested lists in substrait consumer#20953
Open
alexanderbianchi wants to merge 4 commits intoapache:mainfrom
Open
Add support for nested lists in substrait consumer#20953alexanderbianchi wants to merge 4 commits intoapache:mainfrom
alexanderbianchi wants to merge 4 commits intoapache:mainfrom
Conversation
alexanderbianchi
force-pushed
the
bianchi/addnestedsubstraitsupport
branch
2 times, most recently
from
fea10ee to
4abf8f7
Compare
alexanderbianchi
force-pushed
the
bianchi/addnestedsubstraitsupport
branch
from
4abf8f7 to
6eadf6d
Compare
2 tasks
LiaCastaneda
approved these changes
Mar 16, 2026
Contributor
There was a problem hiding this comment.
LGTM
fyi @dd-david-levin since you were looking into this too in #20821
cc @gabotechs could you take a look at this one whenever you have time? I think it’s good to go
vbarua
reviewed
Mar 16, 2026
datafusion/substrait/tests/testdata/test_plans/nested_list_expressions.substrait.json
Outdated
Show resolved
Hide resolved
alexanderbianchi
force-pushed
the
bianchi/addnestedsubstraitsupport
branch
2 times, most recently
from
e3d511d to
d74bd37
Compare
alexanderbianchi
force-pushed
the
bianchi/addnestedsubstraitsupport
branch
from
d74bd37 to
fc7b3e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Adds support for nested array expressions to the substrait consumer. Defined in algebra.proto.
What changes are included in this PR?
Implements the previously unimplemented
consume_nestedforNestedType::List.Are these changes tested?
Yes, unit tests match the testing pattern for substrait literals in
consumer/expr/literal.rs. Snapshot test is added formake_array()path.Are there any user-facing changes?
User's will now be able to send nested list expressions. This change is purely additive all previous consumable Substrait plans will continue to work.