[Minor] Add --simulate-latency / SIMULATE_LATENCY option to dfbench / ./bench.sh#20954
Open
Dandandan wants to merge 5 commits intoapache:mainfrom
Open
[Minor] Add --simulate-latency / SIMULATE_LATENCY option to dfbench / ./bench.sh#20954Dandandan wants to merge 5 commits intoapache:mainfrom
Dandandan wants to merge 5 commits intoapache:mainfrom
Conversation
…tore latency Wraps the local filesystem with ThrottledStore (100ms get, 200ms list) when enabled, allowing benchmarks to measure performance under realistic remote storage conditions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Passes --simulate-latency to all dfbench/imdb benchmark invocations when SIMULATE_LATENCY=true, e.g.: SIMULATE_LATENCY=true ./bench.sh run tpch Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
adriangb
approved these changes
Mar 15, 2026
Contributor
adriangb
left a comment
adriangb
left a comment
There was a problem hiding this comment.
Pending CI fixes and successful test w/ benchmark runner
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…upport Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Hmm seems throttledobjectstore doesn't support files yet |
Contributor
|
We could vendor + submit a patch to arrow-rs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?