fix: Tuple IN null semantics for struct comparisons#21054
Open
xiedeyantu wants to merge 2 commits intoapache:mainfrom
Open
fix: Tuple IN null semantics for struct comparisons#21054xiedeyantu wants to merge 2 commits intoapache:mainfrom
xiedeyantu wants to merge 2 commits intoapache:mainfrom
Conversation
Member
Author
|
Hi @alamb , may I ask if this PR of mine is needed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This PR corrects IN evaluation for tuple/struct comparisons when a candidate row contains NULL in one or more fields.
For example:
now returns NULL instead of false.
This matches standard SQL three-valued logic and aligns DataFusion with PostgreSQL behavior.
What changes are included in this PR?
Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.
Tuple/struct IN now returns NULL when nested NULLs are involved, matching PostgreSQL behavior.