chore: Remove duplicate imports in test code#21061
Merged
alamb merged 1 commit intoapache:mainfrom Mar 21, 2026
Merged
Conversation
Contributor
Author
Member
|
I am also not aware of any clippy setting to warn about such "duplicates". |
martin-g
approved these changes
Mar 20, 2026
Contributor
Author
I first asked Claude Code to see if it could do it; it was a bit slow and unreliable doing it itself, but eventually it decided to write a Python script (attached) that seems like it works pretty well. |
Contributor
|
This is great -- thank you @neilconway and @martin-g |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
clippydoesn't warn aboutusestatements that re-import an item that is already available via a glob import (use super::*), but in many cases theusestatement is redundant and can be safely removed. In particular, there was a lot of test code that did bothuse super::*and also imported items that were imported by the module under test; the test-specific import can be safely removed.What changes are included in this PR?
Are these changes tested?
Yes, via
cargo checkandcargo clippyAre there any user-facing changes?
No.