Skip to content

Refactor percentile UDFs to use TypeSignature API#21074

Open
theirix wants to merge 11 commits intoapache:mainfrom
theirix:rm-aggregates-integers
Open

Refactor percentile UDFs to use TypeSignature API#21074
theirix wants to merge 11 commits intoapache:mainfrom
theirix:rm-aggregates-integers

Conversation

@theirix
Copy link
Contributor

@theirix theirix commented Mar 20, 2026

Which issue does this PR close?

Rationale for this change

Migrating to the modern TypeSignature API: 264030c/datafusion/expr-common/src/signature.rs

What changes are included in this PR?

  • Port remaining UDFs (approx_percentile_cont, approx_percentile_cont_with_weight, stub function) to signature APIs
  • Deprecate INTEGERS and NUMERICS arrays in favour of using the TypeSignature API
  • Theyy are not removed yet, but marked as deprecated to avoid breaking downstream
  • Fix up a SLT for approx_percentile_cont to make sure it returns a float

Are these changes tested?

  • Tests are passing

Are there any user-facing changes?

@github-actions github-actions bot added logical-expr Logical plan and expressions sqllogictest SQL Logic Tests (.slt) functions Changes to functions implementation labels Mar 20, 2026
@github-actions github-actions bot added the core Core DataFusion crate label Mar 20, 2026
@github-actions github-actions bot added the optimizer Optimizer rules label Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate functions Changes to functions implementation logical-expr Logical plan and expressions optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor away usage of NUMERICS/INTEGERS in datafusion/expr-common/src/type_coercion/aggregates.rs

1 participant