Open
Conversation
blaginin
commented
Mar 20, 2026
| submodules: true | ||
| fetch-depth: 1 | ||
| - name: Setup Rust toolchain | ||
| uses: ./.github/actions/setup-builder |
Member
Author
There was a problem hiding this comment.
this sets RUST_BACKTRACE=1 and we have a lot of expected failures in sqlogictests
blaginin
commented
Mar 20, 2026
| available_parallelism() | ||
| .unwrap_or(NonZero::new(1).expect("literal value `1` shouldn't be zero")) | ||
| .get() | ||
| static PARALLELISM: LazyLock<usize> = LazyLock::new(|| { |
Member
Author
Member
Author
There was a problem hiding this comment.
this obviously affects not only tests, happy to apply to only tests, but feels like a good change overall? 🤔
blaginin
commented
Mar 20, 2026
Cargo.toml
Outdated
4ad299f to
34d3034
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This makes sqlite extended finish in 5 minutes: https://github.com/apache/datafusion/actions/runs/23362665318/job/67969547959
Currently on develop it takes 20 minutes (and a month ago it would take two hours 🤯)