Skip to content

fix: set escape_char when simplifying starts_with to LIKE #21086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jackye1995 wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −4
Open

fix: set escape_char when simplifying starts_with to LIKE #21086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc4141d
fix: set escape_char when simplifying starts_with to LIKE
jackye1995 Mar 20, 2026
ab5d6f6
fix tests
jackye1995 Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datafusion/functions/src/string/starts_with.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ impl ScalarUDFImpl for StartsWithFunc {
negated: false,
expr: Box::new(expr),
pattern: Box::new(pattern),
escape_char: None,
escape_char: Some('\\'),
case_insensitive: false,
})));
}
Expand Down
6 changes: 3 additions & 3 deletions datafusion/sqllogictest/test_files/string/string_view.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ EXPLAIN SELECT
FROM test;
----
logical_plan
01)Projection: test.column1_utf8view LIKE Utf8View("äöüß%") AS c1, CASE test.column1_utf8view IS NOT NULL WHEN Boolean(true) THEN Boolean(true) END AS c2, starts_with(test.column1_utf8view, Utf8View(NULL)) AS c3, starts_with(Utf8View(NULL), test.column1_utf8view) AS c4
01)Projection: test.column1_utf8view LIKE Utf8View("äöüß%") ESCAPE '\' AS c1, CASE test.column1_utf8view IS NOT NULL WHEN Boolean(true) THEN Boolean(true) END AS c2, starts_with(test.column1_utf8view, Utf8View(NULL)) AS c3, starts_with(Utf8View(NULL), test.column1_utf8view) AS c4
02)--TableScan: test projection=[column1_utf8view]

## Test STARTS_WITH is rewitten to LIKE when the pattern is a constant
Expand All @@ -370,7 +370,7 @@ EXPLAIN SELECT
FROM test;
----
logical_plan
01)Projection: test.column1_utf8 LIKE Utf8("foo\%%") AS c1, test.column1_large_utf8 LIKE LargeUtf8("foo\%%") AS c2, test.column1_utf8view LIKE Utf8View("foo\%%") AS c3, test.column1_utf8 LIKE Utf8("f\_o%") AS c4, test.column1_large_utf8 LIKE LargeUtf8("f\_o%") AS c5, test.column1_utf8view LIKE Utf8View("f\_o%") AS c6
01)Projection: test.column1_utf8 LIKE Utf8("foo\%%") ESCAPE '\' AS c1, test.column1_large_utf8 LIKE LargeUtf8("foo\%%") ESCAPE '\' AS c2, test.column1_utf8view LIKE Utf8View("foo\%%") ESCAPE '\' AS c3, test.column1_utf8 LIKE Utf8("f\_o%") ESCAPE '\' AS c4, test.column1_large_utf8 LIKE LargeUtf8("f\_o%") ESCAPE '\' AS c5, test.column1_utf8view LIKE Utf8View("f\_o%") ESCAPE '\' AS c6
02)--TableScan: test projection=[column1_utf8, column1_large_utf8, column1_utf8view]

## Test STARTS_WITH works with column arguments
Expand Down Expand Up @@ -950,7 +950,7 @@ EXPLAIN SELECT
FROM test;
----
logical_plan
01)Projection: test.column1_utf8view LIKE Utf8View("foo%") AS c, starts_with(test.column1_utf8view, test.column2_utf8view) AS c2
01)Projection: test.column1_utf8view LIKE Utf8View("foo%") ESCAPE '\' AS c, starts_with(test.column1_utf8view, test.column2_utf8view) AS c2
02)--TableScan: test projection=[column1_utf8view, column2_utf8view]

## Ensure no casts for TRANSLATE
Expand Down
Loading