feat: cap spill merge fan-in#23066
Open
Kevin-Li-2025 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
External sort merge phases currently select spill files based only on memory reservation. With many small spills, a single phase can open enough files to exceed the process file-descriptor limit.
What changes are included in this PR?
datafusion.runtime.max_spill_merge_fan_in(0preserves the current unlimited behavior).SET/RESET/SHOW.Are there any user-facing changes?
Users can cap the number of spill files opened in one external merge pass. The default remains unchanged.
How was this change tested?
cargo test -p datafusion-execution test_max_spill_merge_fan_in_builder_and_dynamic_update --libcargo test -p datafusion-physical-plan spill_merge_fan_in --libcargo test -p datafusion --test core_integration test_max_spill_merge_fan_in_runtime_configcargo test -p datafusion-sqllogictest --test sqllogictests -- set_variable.sltcargo check -p datafusioncargo clippy -p datafusion-execution -p datafusion-physical-plan -p datafusion --lib -- -D warningscargo fmt --all -- --checkdev/update_config_docs.sh