feat: Segment Timout Per Datasource#19221
Open
mshahid6 wants to merge 2 commits intoapache:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to configure perSegmentTimeout per datasource via BrokerDynamicConfig, so different per-segment timeout thresholds for can be set for different datasources e.g. larger datasources may need different thresholds than small ones.
Broker adds per-datasource perSegmentTimeout to query context via BrokerDynamicConfig before forwarding to historicals. Historicals enforce it using the existing perSegmentTimeout mechanism — no historical-side changes needed.
There is also a monitorOnly mode that logs which queries would be affected without enforcing, for safe rollout.
Precedence:
Example API/config
Release note
A per-segment timeout per datasource that is set via BrokerDynamicConfig, enforced by historicals through query context and includes a monitorOnly mode.
Key changed/added classes in this PR
[I can add to docs when the design is reviewed]
This PR has: