feat: MSQ exception handling improvements.#19234
Open
gianm wants to merge 5 commits intoapache:masterfrom
Open
feat: MSQ exception handling improvements.#19234gianm wants to merge 5 commits intoapache:masterfrom
gianm wants to merge 5 commits intoapache:masterfrom
Conversation
This patch makes various changes to MSQ exception handling, with the goal of better compatibility with DruidExceptions: 1) Add DruidExceptionFault, which allows including DruidExceptions in MSQErrorReports without losing any information. 2) Make MSQFault#toDruidException abstract so all fault implementations must reference a specific category and persona. Changed the category and persona of various faults, in situations where the inherited default was not ideal. 3) QueryRuntimeFault no longer generated, instead we're relying fully on DruidException for exceptions that originate in the query runtime. 4) Retain original DruidException, rather than wrapping and re-throwing, in ControllerImpl, SegmentGeneratorFrameProcessor, and RowBasedFrameWriter. 5) Update Either to throw non-DEVELOPER DruidExceptions as-is, rather than wrapping them.
github-actions
bot
added
Area - Documentation
Area - Batch Ingestion
Area - Querying
Area - MSQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch makes various changes to MSQ exception handling, with the goal of better compatibility with DruidExceptions:
Add
DruidExceptionFault, which allows includingDruidExceptioninMSQErrorReportwithout losing any information.Make
MSQFault#toDruidExceptionabstract so all fault implementations must reference a specific category and persona. Changed the category and persona of various faults, in situations where the inherited default was not ideal.QueryRuntimeFaultno longer generated, instead we're relying fully onDruidExceptionfor exceptions that originate in the query runtime.Retain original
DruidException, rather than wrapping and re-throwing, inControllerImpl,SegmentGeneratorFrameProcessor, andRowBasedFrameWriter.Update
Eitherto throw non-DEVELOPERDruidExceptionas-is, rather than wrapping them.