fix: GroupByFrameCombiner selectors must track cursor changes.#19238
Merged
gianm merged 2 commits intoapache:masterfrom Mar 31, 2026
Merged
fix: GroupByFrameCombiner selectors must track cursor changes.#19238gianm merged 2 commits intoapache:masterfrom
gianm merged 2 commits intoapache:masterfrom
Conversation
github-actions
bot
added
Area - Batch Ingestion
Area - MSQ
gianm
force-pushed
the
fix-msq-groupby-combiner
branch
from
45d3649 to
7e73533
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| final int columnNumber = signature.indexOf(dimensionSpec.getDimension()); | ||
| if (columnNumber < 0) { | ||
| return DimensionSelector.constant(null, dimensionSpec.getExtractionFn()); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note test
The groupBy combiner introduced in apache#19193 created selectors incorrectly: they tracked a single underlying cursor rather than following changes in the cursor. This patch addresses it by adding indirection through TrackingDimensionSelector and TrackingColumnValueSelector.
gianm
force-pushed
the
fix-msq-groupby-combiner
branch
from
7e73533 to
5b03634
Compare
clintropolis
approved these changes
Mar 31, 2026
gianm
added a commit
to gianm/druid
that referenced
this pull request
Mar 31, 2026
Follow-ups to apache#19238: 1) Remove a stale comment in GroupByFrameCombinerTest. 2) Make TrackingColumnValueSelector.classOfObject() call its delegate, just like TrackingDimensionSelector does. This likely doesn't matter with how the class is actually used, but it's nice to be consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The groupBy combiner introduced in #19193 created selectors incorrectly: they tracked a single underlying cursor rather than following changes in the cursor. This patch addresses it by adding indirection through
TrackingDimensionSelectorandTrackingColumnValueSelector.