fix: deadlock in HeapMemorySegmentMetadataCache#19240
Merged
kgyrtkirk merged 4 commits intoapache:masterfrom Apr 1, 2026
Merged
fix: deadlock in HeapMemorySegmentMetadataCache#19240kgyrtkirk merged 4 commits intoapache:masterfrom
kgyrtkirk merged 4 commits intoapache:masterfrom
Conversation
gianm
changed the title
gianm
approved these changes
Mar 31, 2026
Member
Author
|
thank you @gianm for taking a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deadlock was happening as:
markCacheSyncedholdsdatasourceToSegmentCachelock; waitsHeapMemoryDatasourceSegmentCachefor an empty onewriteCacheForDataSourceacquiresHeapMemoryDatasourceSegmentCachelock and tries toHeapMemorySegmentMetadataCache#getCacheWithReferencewhich needs thedatasourceToSegmentCachelocktests like
KafkaClusterMetricsTestmay start hanging due to thissee stacktrace and repro here