Skip to content

feat: support broker node eligibility filter in TieredBrokerSelectorStrategy#19502

Open
jtuglu1 wants to merge 1 commit into
apache:masterfrom
jtuglu1:support-broker-node-filter-in-router-strategy
Open

feat: support broker node eligibility filter in TieredBrokerSelectorStrategy#19502
jtuglu1 wants to merge 1 commit into
apache:masterfrom
jtuglu1:support-broker-node-filter-in-router-strategy

Conversation

@jtuglu1
Copy link
Copy Markdown
Contributor

@jtuglu1 jtuglu1 commented May 22, 2026

Description

Adds a hook for router routing strategies to hook into which set of brokers are actually valid to route to. Useful for filtering based on other attributes other than service name, for example maintaining version=2 routers only query version=2 brokers.

Release note

Support broker node eligibility filter in TieredBrokerSelectorStrategy.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@jtuglu1 jtuglu1 requested a review from gianm May 22, 2026 03:39
Copy link
Copy Markdown
Member

@FrankChen021 FrankChen021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.

Reviewed 3 of 3 changed files.


This is an automated review by Codex GPT-5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants