refactor: remove deprecated curator ServiceAnnouncer stuff#19523
Open
clintropolis wants to merge 3 commits into
Open
refactor: remove deprecated curator ServiceAnnouncer stuff#19523clintropolis wants to merge 3 commits into
clintropolis wants to merge 3 commits into
Conversation
Member
FrankChen021
left a comment
There was a problem hiding this comment.
I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.
Reviewed 52 of 52 changed files.
This is an automated review by Codex GPT-5.5
gianm
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
org.apache.druid.curator.discovery.ServiceAnnouncer, and is the third in a series of ZooKeeper cleanup PRs following #19377 and #19500. ThisServiceAnnouncer/CuratorServiceAnnouncerstuff (not to be confused withorg.apache.druid.curator.announcement.ServiceAnnouncer) used the curator-x-discovery library to write service announcements, but nothing in production paths was reading them:DruidLeaderSelector(curator leader latch) + the/v1/leaderHTTP endpoint, not this stuffTaskLocation(host:port reported viaUpdateLocationAction) + theX-Druid-Task-Idheader, not this stuffDruidNodeAnnouncer+DruidNodeDiscoveryProvider, not this stuffThe only consumer of ServiceDiscovery.queryForInstances() in the repo was ServiceAnnouncerTest, verifying its own writes.
The
ChatHandlerProviderinterface has been simplified, as the 3-arg register(key, handler, boolean announce) method was only meaningful when there was an external announce side, and the interface has been collapsed into just a classChatHandlerProvidersince without the productionServiceAnnouncingChatHandlerProviderdoing a bunch of curator stuff it is just a simple registry, making the no-op implementation unecessary.Release note
Removed deprecated legacy ZooKeeper service announcement that was using the curator-x-discovery library. The library dependency has also been removed. The following configs have been removed and will be ignored:
druid.discovery.curator.pathdruid.discovery.curator.useDiscoverydruid.indexer.task.chathandler.typedruid.indexer.chathandler.publishDiscovery