feat: Include supervisorId in Kafka consumer metrics.#19525
Open
gianm wants to merge 2 commits into
Open
Conversation
This patch updates KafkaConsumerMonitor to accept the task's metric builder, which includes supervisorId as well as other dimensions from IndexTaskUtils.setTaskDimensions.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| sortingMapper, | ||
| spec.getIoConfig().getConfigOverrides(), | ||
| spec.getIoConfig().isMultiTopic() | ||
| spec.getIoConfig().isMultiTopic(), |
Member
FrankChen021
left a comment
FrankChen021
left a comment
There was a problem hiding this comment.
| Severity | Findings |
|---|---|
| P0 | 0 |
| P1 | 0 |
| P2 | 2 |
| P3 | 0 |
| Total | 2 |
| Severity | Findings |
|---|---|
| P0 | 0 |
| P1 | 0 |
| P2 | 2 |
| P3 | 0 |
| Total | 2 |
Reviewed 7 of 7 changed files.
This is an automated review by Codex GPT-5.5
Findings that could not be attached inline:
- extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaRecordSupplier.java:92 - [P2] Keep the old KafkaRecordSupplier overloads. The public KafkaRecordSupplier constructors now require metricBuilderSupplier, removing the existing four-argument production constructor and two-argument test constructor signatures. Downstream code that creates a supplier without task metric dimensions will break at compile time or runtime despite null preserving the old behavior. Please retain overloads that delegate to the new constructors with a null supplier.
Member
FrankChen021
left a comment
FrankChen021
left a comment
There was a problem hiding this comment.
Handled the follow-up on KafkaConsumerMonitor constructor compatibility. The author clarified this is effectively internal, so I do not think another inline reply is useful.
I also reviewed the incremental diff and the full prepared diff for new regressions. No new high-confidence findings.
Reviewed 7 of 7 changed files.
This is an automated review by Codex GPT-5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch updates
KafkaConsumerMonitorto accept the task's metric builder, which includessupervisorIdas well as other dimensions fromIndexTaskUtils.setTaskDimensions.