fix: console bugs and ci problems #1397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses console-related fixes for the Dubbo Admin project. The changes primarily focus on configuration management, observability features, logging improvements, and code cleanup.
Changes:
- Fixed configuration structure by separating observability settings from console configuration and adding proper validation
- Corrected logger initialization to support file output with rotation and improved configuration
- Cleaned up unused code files and consolidated version management
Reviewed changes
Copilot reviewed 42 out of 232 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| release/kubernetes/dubbo-samples-shop/dubbo-samples-shop-all.yaml | Added tracing sampling probability configuration (contains critical spelling error) |
| pkg/version/version.go | Reorganized version information structure and fixed variable naming |
| pkg/version/compatibility.go | Removed unused compatibility checking code |
| pkg/version/cobra.go | Removed unused version structure |
| pkg/governor/nacos2/governor.go | Added synchronization delays for config operations |
| pkg/engine/kubernetes/listerwatcher/runtime_instance.go | Added nil checks and fixed identifier naming |
| pkg/discovery/nacos2/listerwatcher/*.go | Added client cleanup in Stop methods |
| pkg/core/logger/log.go | Refactored logging to support both console and file output with rotation |
| pkg/core/*.go | Removed alias helper functions |
| pkg/console/service/*.go | Added observability dashboard functions and fixed constant usage |
| pkg/console/handler/*.go | Refactored dashboard handlers to use new configuration structure |
| pkg/console/model/*.go | Updated model structures for observability requests |
| pkg/config/**/*.go | Restructured configuration with new observability and log configs, added validation |
| app/dubbo-ui/dist/admin/* | Updated UI dist files (binary/generated content) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
release/kubernetes/dubbo-samples-shop/dubbo-samples-shop-all.yaml
Outdated
Show resolved
Hide resolved
|
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 250 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
robocanic
added a commit
that referenced
this pull request
Feb 8, 2026
* Fix: Address the admin issues before the release (#1391) * build: Optimize the styles of some tables, adapt to backend changes, format the code, and package it * chore: remove PR_DESCRIPTION.md file as it is no longer needed * fix: update routing rule handling updated routing rule handling to use constants for HTTP status codes in various components. * build: build & format * feat: enhance error handling and data loading in various components - Added a silent error handling mechanism for specific URLs in the HTTP request module to suppress error messages. - Refactored data loading logic in sceneConfig.vue to load configuration data based on the selected tab, improving user experience. - Updated YAMLView.vue and other components to remove unused button code and optimize imports, enhancing code clarity and maintainability. - Improved error handling in routingRule and dynamicConfig components to ensure better user feedback and debugging. * feat: add new components and enhance YAML and XML editing capabilities - Introduced new JavaScript files for YAML and XML syntax highlighting and editing. - Added components for updating YAML configurations with structured editor interfaces. - Updated index.html to reference new JavaScript bundles for improved functionality. - Enhanced error handling and logging in various components for better debugging. - Removed unused code and optimized imports in YAMLView and related components. * feat: enhance UI components and improve error handling - Added global styles for clickable links in tables to improve user interaction. - Updated routing logic to utilize a dynamic header parameter key for better flexibility. - Enhanced error handling in HTTP requests to suppress messages for specific URLs. - Improved internationalization by adding new translation keys for 'Ready Time' in both English and Chinese. - Refactored various components to optimize code structure and maintainability, including updates to YAML and form views. - Adjusted table and form layouts for better responsiveness and user experience. * refactor: streamline component code and enhance condition handling - Simplified iframe rendering in GrafanaPage.vue for improved readability. - Added checks in ConfigModel.ts to skip undefined keys in matches and parameters. - Optimized YAMLView.vue by condensing MonacoEditor properties for better clarity. - Cleared default request and address matching arrays in formView.vue for cleaner initialization. - Enhanced condition parsing and merging logic in updateByFormView.vue to improve maintainability and readability. * build: build admin * fix: add Apache License headers to YAML files in release/kubernetes (#1393) * feat: enhance UI components, improve error handling, and add routing rule management (#1394) * build: Optimize the styles of some tables, adapt to backend changes, format the code, and package it * chore: remove PR_DESCRIPTION.md file as it is no longer needed * fix: update routing rule handling updated routing rule handling to use constants for HTTP status codes in various components. * build: build & format * feat: enhance error handling and data loading in various components - Added a silent error handling mechanism for specific URLs in the HTTP request module to suppress error messages. - Refactored data loading logic in sceneConfig.vue to load configuration data based on the selected tab, improving user experience. - Updated YAMLView.vue and other components to remove unused button code and optimize imports, enhancing code clarity and maintainability. - Improved error handling in routingRule and dynamicConfig components to ensure better user feedback and debugging. * feat: add new components and enhance YAML and XML editing capabilities - Introduced new JavaScript files for YAML and XML syntax highlighting and editing. - Added components for updating YAML configurations with structured editor interfaces. - Updated index.html to reference new JavaScript bundles for improved functionality. - Enhanced error handling and logging in various components for better debugging. - Removed unused code and optimized imports in YAMLView and related components. * feat: enhance UI components and improve error handling - Added global styles for clickable links in tables to improve user interaction. - Updated routing logic to utilize a dynamic header parameter key for better flexibility. - Enhanced error handling in HTTP requests to suppress messages for specific URLs. - Improved internationalization by adding new translation keys for 'Ready Time' in both English and Chinese. - Refactored various components to optimize code structure and maintainability, including updates to YAML and form views. - Adjusted table and form layouts for better responsiveness and user experience. * refactor: streamline component code and enhance condition handling - Simplified iframe rendering in GrafanaPage.vue for improved readability. - Added checks in ConfigModel.ts to skip undefined keys in matches and parameters. - Optimized YAMLView.vue by condensing MonacoEditor properties for better clarity. - Cleared default request and address matching arrays in formView.vue for cleaner initialization. - Enhanced condition parsing and merging logic in updateByFormView.vue to improve maintainability and readability. * build: build admin * fix: improve error handling and UI updates in GrafanaPage and sceneConfig components - Added conditional checks in GrafanaPage.vue to ensure valid baseURL before constructing the Grafana URL. - Enhanced iframe loading logic to prevent errors when accessing undefined elements. - Updated service.vue to handle potential undefined values in versionGroups, ensuring robust data handling. - Refactored sceneConfig.vue to improve the user experience by adding a conditional rendering for parameter routes, including a message for empty configurations and a button for adding new routes. * refactor: Request to update the Grafana URL * build: build * ♻️ refactor: update route parameters to include name and make pathId/appName optional Update routing structure across instance and traffic management views to: - Add :name parameter to routes for better identification - Make :pathId and :appName optional parameters (with ?) - Affects instance detail, monitor, link tracking, and configuration tabs - Updates dynamic config, routing rule, and tag rule views accordingly This change provides more flexible routing and better resource identification. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * ✨ feat(routing): add routing rule list component and composable Add new RoutingRuleList component and useRoutingRule composable to manage routing rule configurations. Updates addByFormView and updateByFormView to integrate with the new components. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * build: format & build * ✨ feat(routing): enhance routing rule form with comprehensive i18n support Enhance routing rule form functionality with improved internationalization, user interface refinements, and better form handling. - Add comprehensive i18n translations for routing rule fields - Improve form layout and field descriptions - Enhance routing rule list component with better UX - Refactor routing rule composable for better maintainability - Update tab header slots for improved navigation Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * build: format & build --------- Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> * Fix/console (#1397) * fix: create tag rule bug * refactor: config refactor; fix: fix console bugs * fix: instance disable traffic * fix: CI promblems * fix: typo * fix(ui): update footer copyright year to 2026 (#1396) * implement counter by key (#1390) * implement counter by key * chore: trigger CI * Fix counter initialization errors and mesh change detection logic --------- Co-authored-by: WyRainBow <your-email@example.com> * feat: kubernetes deployment manifests and docker file (#1410) * refactor: refactor dockerfile and implement dubbo-admin deployment * fix: deploy manifests --------- Co-authored-by: LGgbond <1493170339@qq.com> Co-authored-by: WyRainBow <weiyu9484@gmail.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> Co-authored-by: Akshit Vig <akshitvig48@gmail.com> Co-authored-by: WyRainBow <your-email@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.
Please check any characteristics that apply to this pull request.