[Optimization] Improve Zookeeper startup wait logic in StartZookeeperWindowsProcessor#16150
Open
Senrian wants to merge 1 commit intoapache:3.3from
Open
[Optimization] Improve Zookeeper startup wait logic in StartZookeeperWindowsProcessor#16150Senrian wants to merge 1 commit intoapache:3.3from
Senrian wants to merge 1 commit intoapache:3.3from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Replace the hardcoded
TimeUnit.SECONDS.sleep(3)with a Curator-based health check to wait for Zookeeper startup.Why this is better
blockUntilConnected()with 3s timeout instead of fixed 3s sleepDubboTestExceptionon failure instead of silently ignoring exceptionsRelated Issue
Fixes #16085
Checklist
3.3branchmvn test)