test: add YamlCodec security tests#16282
Open
jay666mnj wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16282 +/- ##
============================================
- Coverage 60.85% 60.78% -0.08%
+ Complexity 11779 11769 -10
============================================
Files 1953 1953
Lines 89186 89186
Branches 13454 13454
============================================
- Hits 54277 54209 -68
- Misses 29353 29413 +60
- Partials 5556 5564 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oxsean
approved these changes
May 29, 2026
Author
|
Thanks a lot for approving this PR!
Now that we have 2 approvals as required, could this PR be merged? Let me know if anything else is needed.
Thanks,
原始邮件
发件人:Sean Yang ***@***.***>
发件时间:2026年5月29日 18:31
收件人:apache/dubbo ***@***.***>
抄送:yijie zhao ***@***.***>, Author ***@***.***>
主题:Re: [apache/dubbo] test: add YamlCodec security tests (PR #16282)
@oxsean approved this pull request.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you authored the thread.
|
Author
|
Thanks a lot for approving this PR!
Now that we have 2 approvals as required, could this PR be merged? Let me know if anything else is needed.
Thanks,
原始邮件
发件人:Yukina ***@***.***>
发件时间:2026年5月29日 14:16
收件人:apache/dubbo ***@***.***>
抄送:yijie zhao ***@***.***>, Author ***@***.***>
主题:Re: [apache/dubbo] test: add YamlCodec security tests (PR #16282)
@RainYuY approved this pull request.
LGTM
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you authored the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add tests for YamlCodec to ensure YAML Java class tags are checked by Dubbo serialization security.
Brief changelog
Verifying this change
$env:JAVA_TOOL_OPTIONS='-Dfile.encoding=UTF-8'; .\mvnw.cmd -pl dubbo-remoting/dubbo-remoting-http12 -Dtest=YamlCodecTest testFixes #13799