fix(candlestick): support cursor option#21558
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
Ovilia
left a comment
There was a problem hiding this comment.
Thanks for your contribution.
The fixing of this PR may not relates to #21551 , because #21551 requested cursor style when hovering on the grid area of the chart rather than hovering on the candlestick series itself.
With git bisect, I found the diff was caused in 237badb . I would suggest discuss with @100pah and see if this should be a new feature and how this can be fixed.
Thanks
close #21551
Brief Information
This pull request is in the type of:
What does this PR do?
Fixes the missing
cursorsupport oncandlestickseries and adds a manual test page for verification.Fixed issues
cursordoes not take effect oncandlestickseriesDetails
Before: What was the problem?
cursoris a supported option on some series types, but it did not work oncandlestick.The main reason was that
candlestickview did not forward the cursor option to zrender elements:itemModel.getShallow('cursor')series.cursorAs a result, hovering candlestick elements still showed the default cursor.
After: How does it behave after the fixing?
After this change:
series.cursorworks oncandlestickin normal modedata[i].cursoralso works in normal modeseries.cursorworks oncandlestickin large modeThe fix is kept minimal by only wiring the existing cursor option through
CandlestickViewand adding a manual test page:test/candlestick-cursor.htmlThe test page includes:
candlestick-shexampleDocument Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
test/candlestick-cursor.htmlMerging options
Other information
Local verification:
eslinttsc --noEmittest/candlestick-cursor.html