fix(force): prevent graph drifting out of view during layout animation by using center-of-mass pinning#21629
Open
kortschak wants to merge 1 commit into
Open
fix(force): prevent graph drifting out of view during layout animation by using center-of-mass pinning#21629kortschak wants to merge 1 commit into
kortschak wants to merge 1 commit into
Conversation
…n by using center-of-mass pinning
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
This prevents the graph from gliding out of the view during force relaxation.
Fixed issues
Details
Before: What was the problem?
During force relaxation in the graph visualisation , the graph can drift out of the view pane.
Originally raised in https://lists.apache.org/thread/wg71hg2wl9fb9ss4qsll29b0l10w4xkh
After: How does it behave after the fixing?
The center of mass is determined prior to relaxation and the graph's center of mass position is constrained to that during relaxation. The graph no longer drifts, but will likely rotate (this is a harder problem to solve and likely not worth fixing).
Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Merging options
Other information