FINERACT-2637: simpler build commands#5973
Open
meonkeys wants to merge 1 commit into
Open
Conversation
Member
|
@meonkeys can you try rebase against develop. I think this will fix the failing checks. |
Let's simplify our build commands. The Gradle daemon will save on Java startup times. Gradle should handle caching so we shouldn't need to many explicit "-x" exclusions. The shorter commands are easier to read, maintain, and reproduce apart from GitHub Actions (e.g. during local dev/test). If we need to add some -x exclusions back, we can, but ideally we get Gradle to do that kind of fiddly work for us. Guidance from Ádám Sághy: > our gradle task dependencies should be rather reviewed first why any > of the excluded tasks been triggered (hence depended) for the target > task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Let's simplify our build commands. The Gradle daemon will save on Java startup times. Gradle should handle caching so we shouldn't need to many explicit "-x" exclusions. The shorter commands are easier to read, maintain, and reproduce apart from GitHub Actions (e.g. during local dev/test). If we need to add some -x exclusions back, we can, but ideally we get Gradle to do that kind of fiddly work for us.
Guidance from Ádám Sághy:
FINERACT-2637
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.