Skip to content

FINERACT-2635: Add FeignChargesHelper, ChargeRequestBuilders and FeignDelinquencyLifecycleTest#5978

Open
DeathGun44 wants to merge 1 commit into
apache:developfrom
DeathGun44:FINERACT-2635/feign-charges-helper-and-tests
Open

FINERACT-2635: Add FeignChargesHelper, ChargeRequestBuilders and FeignDelinquencyLifecycleTest#5978
DeathGun44 wants to merge 1 commit into
apache:developfrom
DeathGun44:FINERACT-2635/feign-charges-helper-and-tests

Conversation

@DeathGun44

Copy link
Copy Markdown
Contributor

Description

Extends the RestAssured → Feign migration (PR 3 of the roadmap) to the Charges and Delinquency domains.
Key Changes:

  • Added ChargeRequestBuilders: Static typed factories for ChargeRequest generation.
  • Added FeignChargesHelper: 14 pure-Feign methods for global (ChargesApi) and client-level (ClientChargesApi) charge management.
  • Added FeignDelinquencyLifecycleTest: 7 ordered E2E tests verifying delinquency range/bucket CRUD via native Feign.
  • Fixed Swagger Spec: Added 4 missing withdrawal fields to PostChargesRequest in ChargesApiResourceSwagger, ensuring ChargeRequest generation is accurate for PUT requests.
  • Refactored Tests: Swapped duplicated legacy createCharge() logic in 3 enricher/report tests with the new chargesHelper.createLoanDisbursementCharge().
    Note: LoanChargesApi actions (add/pay/waive on specific loans) and Loan Delinquency actions are deferred to the upcoming FeignLoanHelper PR.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@DeathGun44

Copy link
Copy Markdown
Contributor Author

these test failures are unrelated to my changes

@DeathGun44 DeathGun44 force-pushed the FINERACT-2635/feign-charges-helper-and-tests branch from 2050897 to 8c743c3 Compare June 12, 2026 12:02
@DeathGun44

Copy link
Copy Markdown
Contributor Author

this PR only touches files under feign/helpers, feign/modules, feign/tests, and ChargesApiResourceSwagger. the 403 on testLoanCOBPartitioningQuery is not related to my changes.

…nDelinquencyLifecycleTest

Signed-off-by: DeathGun44 <krishnamewara841@gmail.com>
@DeathGun44 DeathGun44 force-pushed the FINERACT-2635/feign-charges-helper-and-tests branch from 8c743c3 to 4ff55c2 Compare June 14, 2026 14:40
@DeathGun44

Copy link
Copy Markdown
Contributor Author

@budaidev @adamsaghy please take a look when you have a moment

@adamsaghy adamsaghy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DeathGun44

Copy link
Copy Markdown
Contributor Author

unrelated SocketTimeoutException failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants