FINERACT-2589: Fix repayment template to return next unpaid installment amount#5985
Open
AshharAhmadKhan wants to merge 1 commit into
Conversation
…nt amount Updated RepaymentTransactionTemplateMapper.schema() to order installments by outstanding balance first, so partially paid loans return the correct next unpaid installment amount instead of always defaulting to the earliest installment by number.
Contributor
Author
|
@adamsaghy failure unrelated to my code. Please retrigger check when you get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes FINERACT-2589
Description
When a loan has been partially repaid, the repayment transaction template was always returning the amount of the first installment by sequence number, even if that installment was already fully paid. This caused the suggested repayment amount to show as zero for borrowers whose earliest installment had been satisfied.
The fix extracts the due amount expressions for principal, interest, fees, and penalties into named variables, then uses them in the ORDER BY clause to prioritize installments with any outstanding balance. Fully paid installments are pushed to the end, while the secondary sort by installment number is preserved to maintain correct ordering within each group.