[FLINK-39832] Fix Oracle NUMBER(p,0) with p>=19 incorrectly mapped to BIGINT#4424
Open
ironman-star wants to merge 1 commit into
Open
[FLINK-39832] Fix Oracle NUMBER(p,0) with p>=19 incorrectly mapped to BIGINT#4424ironman-star wants to merge 1 commit into
ironman-star wants to merge 1 commit into
Conversation
… BIGINT OracleTypeUtils.fromDbzColumn mapped NUMBER(p,0) to BIGINT for all precisions, but Debezium encodes p>=19 as DECIMAL(BYTES). The mismatch caused the sink to read a BinaryRecordData pointer as a long, producing a constant garbage PK (171798691841) and collapsing all rows on upsert. Now returns DECIMAL(p,0) when p>=19, aligned with Debezium runtime behavior.
Author
|
@lvyanquan Would you please review this code? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.apache.org/jira/browse/FLINK-39832
OracleTypeUtils.fromDbzColumn mapped NUMBER(p,0) to BIGINT for all precisions, but Debezium encodes p>=19 as DECIMAL(BYTES). The mismatch caused the sink to read a BinaryRecordData pointer as a long, producing a constant garbage PK (171798691841) and collapsing all rows on upsert.
Fix: return DECIMAL(p,0) when p>=19, aligned with Debezium runtime behavior.
Tested with Oracle XE 11.2, NUMBER(19,0) PK, including 19-digit large IDs (9000000000000000001). Snapshot and incremental (INSERT/UPDATE/DELETE) all verified correct.