[FLINK-39833][pipeline][starrocks] Escape special characters in column comment and default value when building DDL#4425
Open
linguoxuan wants to merge 1 commit into
Open
[FLINK-39833][pipeline][starrocks] Escape special characters in column comment and default value when building DDL#4425linguoxuan wants to merge 1 commit into
linguoxuan wants to merge 1 commit into
Conversation
…n comment and default value when building DDL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the StarRocks pipeline connector builds DDL statements (CREATE TABLE / ALTER TABLE ADD COLUMN), special characters in column comments and default values (such as backslash
\, double quote", newline\n, carriage return\r) are not properly escaped.This causes the generated DDL to be syntactically invalid, leading to schema synchronization failures at runtime.
Root Cause
The column comment and default value strings are directly interpolated into the DDL template
DEFAULT "..."andCOMMENT "..."without any escaping.Fix
Introduce a utility method
StarRocksUtils.escapeSqlStringLiteral()that escapes:\→\\"→""\n/\r→ spaceApply this escaping in:
StarRocksEnrichedCatalog(CREATE TABLE DDL building)StarRocksMetadataApplier(ALTER TABLE ADD COLUMN)StarRocksUtils(initial schema conversion and table comment)