[FLINK-38096] AsyncSinkWriter may hang when configured with a custom rate limiting strategy#27631
Open
HundalTaran wants to merge 3 commits intoapache:masterfrom
Open
[FLINK-38096] AsyncSinkWriter may hang when configured with a custom rate limiting strategy#27631HundalTaran wants to merge 3 commits intoapache:masterfrom
HundalTaran wants to merge 3 commits intoapache:masterfrom
Conversation
…rate limiting strategy AsyncSinkWriter may hang when using a custom rate-limiting strategy that may block new requests when no others are in progress. This issue occurs when implementing rate limits, such as restricting API requests per interval
Collaborator
Contributor
|
Unapproved licenses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
In Async Writer, records are getting stuck on executing rate limiting. So, need to make sure that write should wait only if records are present in flight.
Brief change log
Changed in method of AysncWriter.java class from mailboxExecutor.yield(); to yieldIfThereExistsInFlightRequests();
Also. added junit to cehck this yielding.
An example is provided with bucket4j to test rate limiting scenario.
Verifying this change
Existing junits are getting passed.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no) - noDocumentation