[FLINK-39073][runtime] Defer alignment check for idle splits#27638
Open
Efrat19 wants to merge 2 commits intoapache:masterfrom
Open
[FLINK-39073][runtime] Defer alignment check for idle splits#27638Efrat19 wants to merge 2 commits intoapache:masterfrom
Efrat19 wants to merge 2 commits intoapache:masterfrom
Conversation
If a split emits watermarks far into the future and then goes idle, alignment check will incorrectly mark it paused. As max allowed watermark advances, Source operator will transition the split back to active state, (while its still idle) This change aims to fix the issue by deferring the alignment check for idle splits until they break out of idleness.
Collaborator
Split transitions directly from paused to idle and from idle to pause don't make any sense, improving the logs to allow further analysis. It is a convention for flink metrics system to not fail the job though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
If a split emits watermarks far into the future and then goes idle, alignment check will incorrectly mark it paused.
As max allowed watermark advances, Source operator will transition the split back to active state, (while its still idle)
This change aims to fix the issue by deferring the alignment check for idle splits until they break out of idleness.
Brief change log
currentlyIdleSplitsinsourceOperatorVerifying this change
This change added tests and can be verified. (unitTest)
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation